Fix android preadv #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to support preadv/pwritev calls, which is available after Bionic API level 24. Link: lkl/linux#563 Signed-off-by: Hajime Tazaki <thehajime@gmail.com>
Signed-off-by: Hajime Tazaki <thehajime@gmail.com>
tavip
approved these changes
Feb 19, 2025
ddiss
reviewed
Feb 19, 2025
ddiss
left a comment
ddiss
left a comment
There was a problem hiding this comment.
looks good- thanks! One off-topic comment regarding libfuse3
|
|
||
| RUN sudo apt-get update && \ | ||
| sudo apt-get install -y libfuse-dev libarchive-dev linux-headers-4.4.0-97-generic valgrind libnuma-dev && \ | ||
| sudo apt-get install -y libfuse-dev libarchive-dev linux-headers-generic valgrind libnuma-dev && \ |
There was a problem hiding this comment.
lklfuse recently moved to libfuse3 - I'm not sure about Ubuntu / Debian, but I think we should add libfuse3-dev here. libfuse-dev could then be dropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lkl/linux#563 (comment)
This also contains a fix to not being able to download old package name for x86_64 build.
Cc: @tavip @ddiss